-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add meeting link option #207
base: main
Are you sure you want to change the base?
Conversation
I'll see if I can manage to pass the data option suggested in #206. |
This is actually a lot simpler for now though and is worth considering it's reasonable to think someone would provide meeting link as a baseline for a meeting action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add it as a shorthand as well
https://github.com/pkgjs/meet#shorthand-in-your-custom-meeting-templates
Check the conversions.js file https://github.com/pkgjs/meet/blob/61042a30f295179c24673776877615fa12a6c0bc/lib/conversions.js#L13C1-L25C4
Co-authored-by: Jon Church <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets update the default meeting template to use meetingLink if it is available
The notes default doesn't have a meeting link section, so no need there
https://github.com/pkgjs/meet/blob/main/lib/default-template.js#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meant to request changes on the default template comment
d481039
to
beab348
Compare
To avoid repeating a template due to a link change, the option to add a link is included, reducing template duplication with a simple link
ref: expressjs/discussions#283