Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#9771 Move ORCID functionality into core application #1570

Merged
merged 2 commits into from
Jun 21, 2024
Merged

pkp/pkp-lib#9771 Move ORCID functionality into core application #1570

merged 2 commits into from
Jun 21, 2024

Conversation

ewhanson
Copy link
Contributor

No description provided.

@ewhanson ewhanson mentioned this pull request May 23, 2024
Closed
3 tasks
@ewhanson ewhanson marked this pull request as ready for review May 23, 2024 19:18
bozana
bozana reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@bozana bozana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ewhanson,
What about PublishReviewerWorkToOrcid for OMP? -- The job is dispatched in the PKP-LIB in ThankReviewerForm.
Else, all fine :-)

@ewhanson
Copy link
Contributor Author

ewhanson commented Jun 3, 2024

Thanks @bozana! See my note in OPS (I've done the same for OMP).

@ewhanson ewhanson force-pushed the orcid branch 2 times, most recently from 0962f41 to 93552cc Compare June 7, 2024 22:25
@ewhanson ewhanson merged commit b18ad43 into pkp:main Jun 21, 2024
7 of 8 checks passed
@ewhanson ewhanson deleted the orcid branch June 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozana bozana bozana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewhanson @bozana