Additional fixes and text changes for the about page Stable 3 1 2 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve localized title and abstract for ORCID work metadata.
"Six Ways to Make Your ORCID iD Work for You!" on about page
Show sandbox url in user profile. Update handler to store orcidSandbox flag also for user ORCID authorization.
asmecher
requested changes
Sep 11, 2019
There was a problem hiding this comment.
Looks good, @isgrim, just a couple of small tweaks to recommend. There are a bunch of functions missing their code self-documentation so that would be a welcome addition as well, if you like. Let me know once you've had a chance to look these comments over and push up any changes, and I'll merge and forward-port to master! I haven't tested the changes, just reviewed the code by eye. Thanks!
| $response = json_decode($result, true); | ||
| $orcid = $response['orcid']; | ||
| if (!$orcid) { | ||
| // error during authorization |
There was a problem hiding this comment.
I would recommend using the fatalError function in this case, especially since we're not using e.g. a template to format a user-facing error page in the standard OJS layout. Alternately, we're starting to make more use of Exceptions; that would be OK as well.
| <div class="description"> | ||
| {translate key="plugins.generic.orcidProfile.about.orcidExplanation"} | ||
| </div> | ||
| <h3>{translate key="plugins.generic.orcidProfile.about.howAndWhy.title"}</h3> | ||
| <div class="description"> | ||
| {translate key="plugins.generic.orcidProfile.about.howAndWhy"} | ||
| {$contextName} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I had some time to work on several Issues with the ORCID plugin in OJS 3.1.2.
In this pull request the ORCID icon display problems should be addressed for multiple authors.
Collected here in this issue: https://github.com/pkp/pkp-lib/issues/4935.
Also additional checks during the ORCID authorization should not write empty ORCID Ids to the database, should address the following: https://github.com/pkp/pkp-lib/issues/4852
The about page got the correct text and locale keys for english and german locales, should fix the following issue:
https://github.com/pkp/pkp-lib/issues/5007
I also added code to distinguish betweend sandbox ORCID ids in the user profile display, but not yet for the article page or the contributor form: pkp/pkp-lib#4893
Other issues would be addressed in the future, as we are in the progress of updating our OJS instances to 3.1.2 and the plugin may be used more.
Regards,
Nils Weiher