-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ALTCHA, an alternative to current Google Recaptcha #10456
Open
Godoy0722
wants to merge
2
commits into
pkp:main
Choose a base branch
from
Godoy0722:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+265
−68
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
<?php | ||
|
||
/** | ||
* @file classes/form/validation/FormValidatorAltcha.php | ||
* | ||
* Copyright (c) 2014-2024 Simon Fraser University | ||
* Copyright (c) 2000-2024 John Willinsky | ||
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
* | ||
* @class FormValidatorAltcha | ||
* | ||
* @ingroup form_validation | ||
* | ||
* @brief Form validation check Altcha values. | ||
*/ | ||
|
||
namespace PKP\form\validation; | ||
|
||
use AltchaOrg\Altcha\Altcha; | ||
use AltchaOrg\Altcha\ChallengeOptions; | ||
use APP\core\Application; | ||
use Exception; | ||
use InvalidArgumentException; | ||
use PKP\config\Config; | ||
use PKP\form\Form; | ||
|
||
class FormValidatorAltcha extends FormValidator | ||
{ | ||
/** @var string The response field containing the ALTCHA response */ | ||
private const ALTCHA_RESPONSE_FIELD = 'altcha'; | ||
/** @var string The initiating IP address of the user */ | ||
private $_userIp; | ||
|
||
/** | ||
* Constructor. | ||
* | ||
* @param string $userIp IP address of user request | ||
* @param string $message Key of message to display on mismatch | ||
*/ | ||
public function __construct(Form $form, string $userIp, string $message) | ||
{ | ||
parent::__construct($form, self::ALTCHA_RESPONSE_FIELD, FormValidator::FORM_VALIDATOR_REQUIRED_VALUE, $message); | ||
$this->_userIp = $userIp; | ||
} | ||
|
||
// | ||
// Public methods | ||
// | ||
/** | ||
* @see FormValidator::isValid() | ||
* Determine whether or not the form meets this ALTCHA constraint. | ||
* | ||
*/ | ||
public function isValid(): bool | ||
{ | ||
$form = $this->getForm(); | ||
try { | ||
$this->validateResponse($form->getData(self::ALTCHA_RESPONSE_FIELD), $this->_userIp); | ||
return true; | ||
} catch (Exception $exception) { | ||
$this->_message = 'common.captcha.error.missing-input-response'; | ||
return false; | ||
} | ||
} | ||
|
||
/** | ||
* Validates the ALTCHA response | ||
* | ||
* @param string|null $response The ALTCHA response | ||
* @param string|null $ip The user IP address (defaults to null) | ||
* | ||
* @throws Exception Throws in case the validation fails | ||
*/ | ||
public static function validateResponse($response, ?string $ip = null): void | ||
{ | ||
if (!empty($ip) && !filter_var($ip, FILTER_VALIDATE_IP)) { | ||
throw new InvalidArgumentException('Invalid IP address.'); | ||
} | ||
|
||
if (empty($response)) { | ||
throw new InvalidArgumentException('The ALTCHA user response is required.'); | ||
} | ||
|
||
$hmacKey = Config::getVar('captcha', 'altcha_hmackey'); | ||
if (empty($hmacKey)) { | ||
throw new Exception('The ALTCHA is not configured correctly, the HMAC key is missing.'); | ||
} | ||
|
||
$payload = (array) json_decode(base64_decode($response)); | ||
|
||
if (!Altcha::verifySolution($payload, $hmacKey)) { | ||
throw new Exception('The ALTCHA validation failed.'); | ||
} | ||
} | ||
|
||
/** | ||
* Add ALTCHA javascript on the journal header | ||
* | ||
* @param TemplateManager $templateMgr | ||
*/ | ||
public static function addAltchaJavascript(&$templateMgr): void | ||
{ | ||
$request = Application::get()->getRequest(); | ||
$altchaPath = $request->getBaseUrl() . '/lib/pkp/js/lib/altcha/altcha.min.js'; | ||
|
||
$altchaHeader = '<script async defer src="' . $altchaPath . '" type="module"></script>'; | ||
$templateMgr->addHeader('altcha', $altchaHeader); | ||
} | ||
|
||
public static function insertFormChallenge(&$templateMgr): void | ||
{ | ||
$options = new ChallengeOptions([ | ||
'hmacKey' => Config::getVar('captcha', 'altcha_hmackey'), | ||
'number' => Config::getVar('captcha', 'altcha_encrypt_number') ?: 10000, // Default value for a 3 to 5 seconds average solving time | ||
]); | ||
|
||
$challenge = (array) Altcha::createChallenge($options); | ||
|
||
$templateMgr->assign('altchaEnabled', true); | ||
$templateMgr->assign('altchaChallenge', $challenge); | ||
} | ||
} | ||
|
||
if (!PKP_STRICT_MODE) { | ||
class_alias('\PKP\form\validation\FormValidatorAltcha', '\FormValidatorAltcha'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's required for some other reason, the
class_alias
es should only be provided for backwards compatibility; new code shouldn't require it except in a few exceptional cases.