pkp/pkp-lib#9707 use weblate locales for ui #10569
Conversation
bozana
force-pushed
the
9707
branch
3 times, most recently
from
8fb9c58
to
7610a26
Compare
classes/i18n/Locale.php
Outdated
| $filterByLocales = array_keys(array_intersect_key($locales, array_flip($filterByLocales))); | ||
| $locales = array_intersect_key($locales, array_flip($filterByLocales)); |
There was a problem hiding this comment.
The code is similar, so if we inverse the variables, the value can be reused :)
| $filterByLocales = array_keys(array_intersect_key($locales, array_flip($filterByLocales))); | |
| $locales = array_intersect_key($locales, array_flip($filterByLocales)); | |
| $locales = array_intersect_key($locales, array_flip($filterByLocales)); | |
| $filterByLocales = array_keys($locales); |
classes/i18n/Locale.php
Outdated
| { | ||
| return $this->weblateLocaleNames ??= (function (): array { | ||
| $file = Core::getBaseDir() . '/' . PKP_LIB_PATH . '/lib/weblateLanguages/languages.json'; | ||
| $key = __METHOD__ . self::MAX_SUBMISSION_LOCALES_CACHE_LIFETIME . filemtime($file); |
There was a problem hiding this comment.
How likely is this file to change? The current value is 1 year.
| $key = __METHOD__ . self::MAX_SUBMISSION_LOCALES_CACHE_LIFETIME . filemtime($file); | |
| $key = __METHOD__ . static::MAX_WEBLATE_LOCALES_CACHE_LIFETIME. filemtime($file); |
There was a problem hiding this comment.
This file comes with the installation/upgrade. I suppose then (at installation or upgrade) also the cache will be cleared?
I do not think the users will get it in between.
What would you then suggest the lifetime to be?
| ]; | ||
|
|
||
| $schemaLocName = (DB::connection() instanceof PostgresConnection) ? 'TABLE_CATALOG' : 'TABLE_SCHEMA'; | ||
| $renameLocale = fn (string $l) => collect(DB::select("SELECT DISTINCT TABLE_NAME FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_NAME = ? AND {$schemaLocName} = ?", [$l, DB::connection()->getDatabaseName()])) |
There was a problem hiding this comment.
I think it's ok to use the Laravel syntax here (e.g. DB::table()), it will already return a collection.
There was a problem hiding this comment.
Also, I think it's possible to retrieve the metadata using the Laravel stuff (e.g. DB::connection()->getSchemaBuilder()->getTables()), just sounds more flexible than writing custom queries.
| * This can be ambiguous if several locales are defined for the same language. In this case we'll use the primary locale to disambiguate. | ||
| * If that still doesn't determine a unique locale then we'll choose the first locale found. | ||
| */ | ||
| public static function getLocaleFrom3LetterIso(?string $iso3Letter): ?string |
There was a problem hiding this comment.
This function is then deprecated from 3.5
s. #9707