Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9790 Fix color-picker value binding #336

Merged
merged 1 commit into from
Mar 19, 2024
Merged

pkp/pkp-lib#9790 Fix color-picker value binding #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Form/fields/FieldColor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
/>
<div class="pkpFormField__control">
<color-picker
:value="currentValue"
:model-value="currentValue"
:disable-alpha="true"
@input="setValue"
@update:model-value="setValue"
/>
<field-error
v-if="errors && errors.length"
Expand Down Expand Up @@ -70,6 +70,7 @@ export default {
* @param {String} newVal
*/
setValue: function (newVal) {
console.log('set value triggered');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be removed later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasraoni Ops, thanks for catching that!

if (newVal.hex === this.currentValue) {
return;
}
Expand Down