Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10447 Create new ButtonIcon component #413

Merged
merged 8 commits into from
Sep 24, 2024
Merged

pkp/pkp-lib#10447 Create new ButtonIcon component #413

merged 8 commits into from
Sep 24, 2024

Conversation

blesildaramirez
Copy link
Collaborator

No description provided.

@blesildaramirez blesildaramirez force-pushed the i10447 branch 3 times, most recently from a633c5c to 482ef1e Compare September 23, 2024 13:33
@blesildaramirez blesildaramirez marked this pull request as ready for review September 23, 2024 14:04
@blesildaramirez
Copy link
Collaborator Author

blesildaramirez commented Sep 23, 2024 •
edited
Loading

Code review notes:

  1. I included new icons in the PR, although should be address on a separate one but I did not include all new icons from Figma. I'll do the rest of additions soon for Migrate icons to svg pkp-lib#9626
  2. Failing test for DropdownActions component, this is because I removed the <div class="sr-only"></div> and used aria-label for the <button> instead. Update: this is now fixed.
  3. Removed fixed width and height on Expand and History icons.

@blesildaramirez blesildaramirez merged commit c927175 into pkp:main Sep 24, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jardakotesovec jardakotesovec Awaiting requested review from jardakotesovec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blesildaramirez