Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 542: Implement CombatPoints, Crystal and CrystalPerPrice Calculation in ProductStateHandler #564

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix Issue 542: Implement CombatPoints, Crystal and CrystalPerPrice Calculation in ProductStateHandler #564

wants to merge 9 commits into from

Conversation

Spoomer
Copy link
Contributor

@Spoomer Spoomer commented Dec 10, 2024

fixes #542

Changes

  • add IItemProductCalculationService for the Calculation
  • moved code from ProductStateHandler to IItemProductCalculationService
  • add map from Lib9c.Models.Items.Equipment to Nekoyume.Model.Item.Equipment
  • fixed code in ProductStateHandler for finding existing products in the DB
  • add ProductMigrator in Mimir.Initializer (I can also move it to an own project like Mimir.Migrator if you want)

Atralupus
Atralupus requested changes Dec 11, 2024
View reviewed changes
Mimir.Initializer/Program.cs Show resolved Hide resolved
Mimir.Initializer/Mimir.Initializer.csproj Show resolved Hide resolved
Mimir.Initializer/Program.cs Outdated Show resolved Hide resolved
Mimir.Worker/Services/ItemProductCalculationService.cs Outdated Show resolved Hide resolved
Mimir.Worker/Services/ItemProductCalculationService.cs Outdated Show resolved Hide resolved
@Atralupus
Copy link
Member

Thank you for your contribution! 😄

Atralupus
Atralupus approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Atralupus Atralupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll apply next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal left review comments

@Atralupus Atralupus Atralupus approved these changes

@boscohyun boscohyun Awaiting requested review from boscohyun

Assignees

@Spoomer Spoomer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CombatPoints, Crystal and CrystalPerPrice Calculation in ProductStateHandler
3 participants
@Spoomer @Atralupus @moreal