Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment in CI #77

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Use environment in CI #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3476f
Use release environment in CI
trungleduc Mar 11, 2024
f4bd1b0
Update prep-release workflow
trungleduc Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions .github/workflows/prep-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: 'Step 1: Prep Release'
name: "Step 1: Prep Release"
on:
workflow_dispatch:
inputs:
version_spec:
description: 'New Version Specifier'
default: 'next'
description: "New Version Specifier"
default: "next"
required: false
branch:
description: 'The branch to target'
description: "The branch to target"
required: false
post_version_spec:
description: 'Post Version Specifier'
description: "Post Version Specifier"
required: false
since:
description: 'Use PRs with activity since this date or git reference'
description: "Use PRs with activity since this date or git reference"
required: false
since_last_stable:
description: 'Use PRs with activity since the last stable git tag'
description: "Use PRs with activity since the last stable git tag"
required: false
type: boolean
jobs:
Expand All @@ -25,24 +25,18 @@ jobs:
steps:
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- uses: actions/create-github-app-token@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we need the actions/create-github-app-token@v1 step in the prep-release workflow?

The example workflows don't seem to have it: https://github.com/jupyter-server/jupyter_releaser/blob/main/example-workflows/prep-release.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah indeed, I used to use GITHUB_ADMIN_TOKEN in the prep-release step, but actually GITHUB_TOKEN is enough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we would be fine using the workflows from https://github.com/jupyter-server/jupyter_releaser/blob/main/example-workflows/ directly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean importing the workflow from jupyter-releaser? I don't know how to do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, just copy pasting it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

id: app-token
with:
app-id: ${{ vars.APP_ID }}
private-key: ${{ secrets.APP_PRIVATE_KEY }}

- name: Prep Release
id: prep-release
uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2
with:
token: ${{ steps.app-token.outputs.token }}
token: ${{ secrets.GITHUB_TOKEN }}
version_spec: ${{ github.event.inputs.version_spec }}
post_version_spec: ${{ github.event.inputs.post_version_spec }}
target: ${{ github.event.inputs.target }}
branch: ${{ github.event.inputs.branch }}
since: ${{ github.event.inputs.since }}
since_last_stable: ${{ github.event.inputs.since_last_stable }}

- name: '** Next Step **'
- name: "** Next Step **"
run: |
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"
1 change: 1 addition & 0 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:
jobs:
publish_release:
runs-on: ubuntu-latest
environment: release
permissions:
id-token: write
steps:
Expand Down
Loading