Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #82

Closed
wants to merge 3 commits into from
Closed

Fix ci #82

wants to merge 3 commits into from

Conversation

trungleduc
Copy link
Collaborator

@trungleduc trungleduc commented Apr 3, 2024

Skip releasing the npm package.

@trungleduc trungleduc force-pushed the fix-ci branch 5 times, most recently from 64c5d2d to e5a397b Compare April 5, 2024 07:55
@trungleduc trungleduc requested a review from jtpio April 5, 2024 07:55
@jtpio
Copy link
Member

jtpio commented Apr 5, 2024

Maybe skipping the npm steps completely can also help make CI a bit faster (example skipping check-python here: https://github.com/voila-dashboards/voici/blob/df8c17b3caab83b0de6493e096278e0fd8300784/pyproject.toml#L15)

@jtpio
Copy link
Member

jtpio commented Apr 5, 2024

Although thinking more about it, it can still be useful to perform these checks to make sure the npm package builds fine and is correctly structured.

@trungleduc trungleduc closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants