Add splash to simulator #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The circleci builds have been failing with this error since build 81 - 89f70df These changes should have no effect on android builds, and should therefore be safe to merge. |
Change simulator splash config from hardcoded autoHide: true to use the splash config from the manifest if it exists (falls back to autoHide: true) if no splash config is found.
collingreen
force-pushed
the
add-splash-to-simulator
branch
from
5321194 to
154ab5e
Compare
|
Builds no longer fail on master, was caused by an incompatibility with an npm library and node.js in native-ios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.