remove j2v8 from android demo altogether (still some comments)

player-ui · Jul 2, 2024 · 051a078 · 051a078
1 parent 27dcd2c
commit 051a078
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -188,9 +188,8 @@ maven.install(
         "com.facebook.stetho:stetho:1.5.1",
 
         # Hermes
-        # TODO: Using prebuilt android hermes artifact for POC, can build manually for optimization
-        "com.facebook.react:hermes-android:0.74.1",
         "com.facebook.fbjni:fbjni-java-only:0.6.0",
+        "com.facebook.fbjni:fbjni:0.6.0",
         "com.facebook.soloader:soloader:0.11.0",
 
         # Test utils

diff --git a/android/demo/defs.bzl b/android/demo/defs.bzl
@@ -7,8 +7,8 @@ maven_main = [
     #"@maven//:com_squareup_leakcanary_leakcanary_android",
 
     # TODO: Pull these from j2v8-android-debug
-    "@maven//:com_github_AlexTrotsenko_j2v8_debugger",
-    "@maven//:com_facebook_stetho_stetho",
+    #    "@maven//:com_github_AlexTrotsenko_j2v8_debugger",
+    #    "@maven//:com_facebook_stetho_stetho",
 
     # TODO: Pull these from hermes-android
     #    "@maven//:com_facebook_fbjni_fbjni",

diff --git a/...mo/src/main/java/com/intuit/playerui/android/reference/demo/ui/base/BasePlayerFragment.kt b/...mo/src/main/java/com/intuit/playerui/android/reference/demo/ui/base/BasePlayerFragment.kt
@@ -8,7 +8,7 @@ import androidx.fragment.app.viewModels
 import androidx.lifecycle.lifecycleScope
 import androidx.navigation.fragment.findNavController
 import com.afollestad.materialdialogs.MaterialDialog
-import com.alexii.j2v8debugger.StethoHelper
+//import com.alexii.j2v8debugger.StethoHelper
 import com.intuit.playerui.android.lifecycle.ManagedPlayerState
 import com.intuit.playerui.android.lifecycle.PlayerViewModel
 import com.intuit.playerui.android.reference.demo.lifecycle.DemoPlayerViewModel