Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CJS support for React Player #525

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Oct 2, 2024

leven 4.0.0 is esm only and since we distribute esm and cjs we need to downgrade to a version of leven with cjs support

Releaae Notes

Fix CJS support for Reqct player

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.9.2-next.1

Changelog

🐛 Bug Fix

Authors: 2

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Oct 2, 2024
@KetanReddy KetanReddy requested a review from a team October 2, 2024 22:47
@KetanReddy KetanReddy self-assigned this Oct 2, 2024
@KetanReddy KetanReddy requested a review from adierkens as a code owner October 2, 2024 22:48
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (9a3514c) to head (aacb9b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         341      341           
  Lines       27311    27311           
  Branches     1944     1944           
=======================================
  Hits        25103    25103           
  Misses       2194     2194           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants