Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] initial riscv cabi #6

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

[WIP] initial riscv cabi #6

wants to merge 13 commits into from

Conversation

realqhc
Copy link
Collaborator

@realqhc realqhc commented May 17, 2022

Change-Id: Id4bf54bb8da5cb3b98769809ad316f14101b0ff1

Shao-Ce SUN and others added 8 commits May 7, 2022 14:34
Change-Id: Id4bf54bb8da5cb3b98769809ad316f14101b0ff1
Change-Id: Id5696e9d827464c0bb572b56c0d25ce8da5b65e7
Change-Id: Ia2be82030b194d799eaf063ac925d37db36b1b43
Copy link
Collaborator

@luxufan luxufan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unittests on abi still need to be added.

@@ -158,6 +159,9 @@ EightByteInfo::EightByteInfo(Btype *bt, TypeManager *tmgr)
determineABITypesForARM_AAPCS();
}
break;
case llvm::CallingConv::C:
determineAPITypesForRISC_V();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here need to check that the current target is RISC-V. As far as I know, we can't get target info in EightByteInfo class. Maybe we can add target info to typemanager then we can access target info by it. But doing this is not a high priority.

bridge/go-llvm-cabi-oracle.cpp Show resolved Hide resolved
@luxufan
Copy link
Collaborator

luxufan commented May 23, 2022

The error output unsupported llvm::CallingConv::ID 0 needs to be deleted.

Change-Id: Ic9ada21c3689d2fc9e63d3c425b906f4cfd43f38
Change-Id: I7a7a370ef8f065a90f98bf83044cdc3b8ca4ec4f
Change-Id: Iba5040379c6233672e1670ebdaa7200e794c2db1
Change-Id: Ided89d4e797d443242ec3ca227595f945bb73d28
Change-Id: I3b3391046000b2b908c8dbd657f76e44054d0101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants