Skip to content

Commit

Permalink
Bump plugins and use go_toolchain (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
samwestmoreland authored May 14, 2024
1 parent 0bb34da commit a47c209
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 15 deletions.
14 changes: 10 additions & 4 deletions .plzconfig
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
[FeatureFlags]
ExcludeProtoRules = true
ExcludeGoRules = true
[Please]
Version = 17.8.7

[proto]
protoctool = //third_party/proto:protoc
protocgoplugin = //third_party/go:protoc-gen-go
language = go

[Parse]
PreloadSubincludes = ///python//build_defs:python

[Plugin "go"]
Target = //plugins:go
ImportPath = github.com/please-build/proto-rules
GoTool = //third_party/go:toolchain|go

[Plugin "python"]
Target = //plugins:python

[PluginDefinition]
Name = proto

[PluginConfig "definitions"]
Help = A subinclude target containing a build definition that register a new languages using proto_language()
Help = A subinclude target containing a build definition that registers a new language using proto_language()
ConfigKey = LanguageDef
Repeatable = true
Inherit = true
Expand Down
4 changes: 0 additions & 4 deletions BUILD

This file was deleted.

6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Version 0.4.0
-------------
* Bump plugin versions
* Use go_toolchain


Version 0.3.1
-------------
* Remove specialisation for aarch64
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.3.1
0.4.0
10 changes: 7 additions & 3 deletions plugins/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
plugin_repo(
name = "go",
plugin = "go-rules",
revision = "v0.5.1",
)
revision = "v1.17.1",
)

plugin_repo(
name = "python",
revision = "v1.6.0",
)
3 changes: 1 addition & 2 deletions test/BUILD
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# Tests on the proto rules.
# Tests on the legacy proto rules.

subinclude("///proto//build_defs:legacy")


grpc_library(
name = "flags_proto",
srcs = ["flags.proto"],
Expand Down
8 changes: 7 additions & 1 deletion third_party/go/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
subinclude("///go//build_defs:go")

go_toolchain(
name = "toolchain",
install_std = True,
version = "1.22.3",
)

go_module(
name = "protoc-gen-go",
binary = True,
Expand Down Expand Up @@ -232,4 +238,4 @@ go_module(
module = "cloud.google.com/go",
version = "v0.65.0",
visibility = ["PUBLIC"],
)
)

0 comments on commit a47c209

Please sign in to comment.