10.0 add product configurator to purchase order

[elemire]

Add the same functions as Sale Order to Purchase Order.
Add new option to use a product variant if exist rather than creating a new variant each time.

[codecov-io]

Codecov Report

Merging #42 into 10.0 will decrease coverage by 0.81%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             10.0      #42      +/-   ##
==========================================
- Coverage   59.13%   58.31%   -0.82%     
==========================================
  Files          14       15       +1     
  Lines        1358     1377      +19     
==========================================
  Hits          803      803              
- Misses        555      574      +19

Impacted Files	Coverage Δ
product_configurator/models/product.py	74.7% <100%> (+0.07%)	⬆️
product_configurator_purchase/models/purchase.py	58.33% <58.33%> (ø)
...configurator_wizard/wizard/product_configurator.py	25.48% <6.45%> (-0.93%)	⬇️
website_product_configurator/controllers/main.py	73.82% <0%> (+0.17%)	⬆️
product_configurator/models/product_config.py	77.17% <0%> (+0.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3901781...5d81995. Read the comment docs.

[PCatinean]

@elemire I know it's been ages since you submitted this and I just kept postponing the reply.

Thanks for submitting the PR it's really good to extend the configuration functionality to other modules. With this submitted I realized making the default wizard bound to the sale module was a mistake.

I have a refactoring in progress that abstracts this and if you are still interested in rebasing your code then I will gladly review the PR.

Sorry for the late reply once more and thanks for the contribution!

[elemire]

Hello, Yes I am still interested in working with the module. It’s a very nice one. I have also advanced on my side but as I ran out of time I did not send any new pull request. I wanted to add tests and refactor the code before sending another one. I will try to work on that in June. Thanks Éric Lemire Analyste-Développeur Sénior | Division Applications d’affaires MICROCOM Bilingue Couleur +1-514-645-3533 | 1-877-640-3533 X 708 6845 JEAN-TALON EST, Montréal, (Québec) H1S 1N2 AVIS DE CONFIDENTIALITÉ – Cette communication pourrait renfermer des informations privilégiées ou confidentielles. Si vous n’êtes pas la personne à laquelle s’adresse ce message ou si vous avez reçu cette communication par erreur, veuillez en informer l’expéditeur et supprimer le message sans le copier, le faire suivre et/ou en divulguer le contenu. P Avez-vous vraiment besoin d'imprimer ce document? Pensez à l'environnement !. From: Paul Catinean [mailto:[email protected]] Sent: 31 mai 2017 05:54 To: pledra/odoo-product-configurator Cc: Eric Lemire; Mention Subject: Re: [pledra/odoo-product-configurator] 10.0 add product configurator to purchase order (#42) @elemire <https://github.com/elemire> I know it's been ages since you submitted this and I just kept postponing the reply. Thanks for submitting the PR it's really good to extend the configuration functionality to other modules. With this submitted I realized making the default wizard bound to the sale module was a mistake. I have a refactoring in progress that abstracts this and if you are still interested in rebasing your code then I will gladly review the PR. Sorry for the late reply once more and thanks for the contribution! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AEcsYNFPM419TdzmTQGgLTBauboricPmks5r_TixgaJpZM4MnFNp> . <https://github.com/notifications/beacon/AEcsYGYbeFtWDaPAM9PuPUCxd4yvEkKGks5r_TixgaJpZM4MnFNp.gif>

[richard-willdooit]

@elemire @PCatinean
I was, likewise, going to give this a review after we got a few of the other bits and pieces sorted.

[PCatinean]

@elemire @richard-willdooit please wait for the refactored version before extending the configurator to other modules. I've managed to separate the logic completely and have a new model inherit the base one so custom fields and logic can be applied to each particular case. Also base logic to be applied to all configurators can be done with just _inherit. I think it's much cleaner this way and a better approach