added externalTrafficPolicy to service #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koiralasandesh
force-pushed
the
master
branch
from
fadb3c1 to
eb4ddcf
Compare
cilindrox
approved these changes
Dec 3, 2024
|
Thanks @koiralasandesh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NodePort is used, plex container is unable to determine the user IP because k8s does NAT.
Because of this, all traffic seems to originate from the cluster itself.
This breaks a bunch of plex functionalities like determining bitrate for transcode and many other that rely on determining if the user is in LAN or WAN.
Setting
externalTrafficPolicy: Localwill allow Plex to determine the actual IP of user because this disables k8s NAT.But this setting comes with caveats: the pods can only be accessed by the specific Node IP where the pod is running.
Read more here:
https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/#preserving-the-client-source-ip
https://access.redhat.com/solutions/7028639
This is my first time contributing, please let me know if there is specific branching requirements. I could not find any guidelines to contributing. Thanks!