-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add description on creating a frontend project with cookieplone an… #1649
Conversation
…d add some howtos (add-ons, theme, logo)
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on documentation, but I'm worried it could be confusing to add docs about a tool that's in experimental status. I think the general plan is to make cookiecutter-plone-starter use cookiecutter-volto once we're confident that that works well, and then it won't be necessary to use cookiecutter-volto directly unless you're in the specific situation of wanting a new frontend to use with an existing backend.
@davisagli Thank you for the information. |
@davisagli the purpose of this PR, as discussed at the Alpine Sprint, is to publish a how-to guide for
There was strong sentiment expressed at the Alpine Sprint that Of course, and as always, we can revise and change tack to the changing winds. I want all of us to sail in the same direction on this ship. |
IMO it is favorable to have the cookiecutters documented separately.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made suggestions to re-order and restructure a few things. We should do at least one more pass, to make sure it flows properly.
@stevepiercy @jensens I think we basically agree on most of how you are thinking about cookiecutter-volto, and I withdraw my objection to adding this documentation. However, I have one request which I'll explain below. As a general strategy I think it makes sense to have high-quality (tested, documented) scaffolds focused on particular pieces of our stack (i.e. Volto, the Plone backend, a deployment solution). There can even be multiple scaffolds for alternative approaches (i.e. one for a deployment using Docker Swarm, another for a deployment using Kubernetes...) Then cookiecutter-plone-starter should become a wrapper that calls the other scaffolds as tools, for someone who is new and doesn't know what pieces they need. (This could also be a new cookiecutter if that's easier to accomplish, but I've been thinking about it as an evolution of cookiecutter-plone-starter.) cookiecutter-plone-starter already uses this wrapper approach for generating a volto project using the yeoman-based generator. cookiecutter-volto is a clear improvement over that (because yeoman is not maintained well these days, and because cookiecutter-volto uses pnpm which makes it easier to develop a Volto addon along with other packages). So I've been assuming that we at least want to update cookiecutter-plone-starter to use cookiecutter-volto. Anyway, my remaining request about this documentation is that I think it could use a clearer introduction which mentions when it would be appropriate to use cookiecutter-volto instead of the existing install docs based on cookiecutter-plone-starter. cookiecutter-volto is great if you are developing something that is frontend only (and just want to run a non-customized Plone backend via docker) but it doesn't give you everything you need if you also want to customize the backend and deploy the solution. Right? |
@davisagli @stevepiercy @jensens I added the information that cookiecutter-volto currently only supports frontend development to the introduction see here. |
We are sprinting on the cookiecutters at the Axolote Sprint in Mexico City this week, and there may be more changes. I'll push commits to reflect any changes that arise. |
@davisagli @stevepiercy @jensens If it really should run cookiecutter-volto for the volto_addon option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cookiecutter-volto is now deprecated.
To get the same features you should use pipx run cookieplone fromtend_addon
@animus888 if you can make it to the Beethoven Sprint remotely in Discord, there is a daily stand-up at 9:30 AM CET, and a 24/7 chat channel at https://discord.com/channels/786421998426521600/971310680114360340. There has been more progress on the cookiecutters, and things might change again. It would be good to chat with the core developers on this item, especially because they want feedback on its usage. |
@stevepiercy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevepiercy this link blocks the checks for my pull request.. 😿 what else can I do?
It was temporary. It's OK to ignore. |
Ok, I will try if the original link works now. |
@animus888 @davisagli picked up your work in this PR, expanded it in #1714, and I did a thorough walk through and review. I'm closing this PR in favor of that one. Would you please review the other PR and walk through it? I'd appreciate your feedback. Thank you! |
…d add some howtos (add-ons, theme, logo)
Description
documentation part on creating a project with cookiecutter-volto and add some howtos (add-ons, theme, logo).