-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image for 6.1.0b1 #151
Image for 6.1.0b1 #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also:
- change the default branch to 6.1.x so that the nightly build uses this
- configure branch protection for the 6.1.x branch
- update the release.yml action so that it only sets IS_LATEST for the correct release series (6.0.x until we have a final release of 6.1)
The test failed trying to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Hmm waiti. There’s a testing errror. When create-site runs. The plone.volto:default-homepage has a problem. Ah David noted it already as well. |
Yes (though I don't use the nightly). We can do this after this PR actually works and is merged and released.
Done.
Done. |
This comes from the I did not try the new script myself, nor build the image locally. The tests now fail at I quit for today, and likely this weekend. |
I have tried to replicate the failing lests by trying to run the test suite locally, but are there any requirements for an OS and/or bash version? When I run this on a Mac with Bash 5 (make build-images, then use /test/run.sh) I see several errors before the test suite components even start. Then I do see the plone-basics tests hanging. the main run.sh script also seeems to have regressions, for examlpe |
Confirmed that the test suite should be run in recent (Ubuntu) linux only, it runs fine for plone-backend 6.0.13 when I build locally in an Ubuntu 22.04 VM. (using Vmware Fusion on Mac). Now lets test with this branch. |
@fredvd @mauritsvanrees The new distributions-based launch page has different text than what the tests were checking for. I updated the tests, let's see how it goes. I also can't easily run the tests locally since they use some bash features that I don't have on macOS. |
@mauritsvanrees Thanks for working on the site creation script. I'd like to keep support for ADDITIONAL_PROFILES if possible, by running the profiles separately after installing the distribution. I'll try to add this next... |
I updated my bash on my mac to 5 using homebrew and use jt as the default in my Terminals/iTerm2. , but it still seems very different from the bash 5 in Ubuntu. |
It's not a separate page now, and it's a React app so harder to test for
@mauritsvanrees @fredvd There we go! |
Nice! |
@fredvd Is there a reason we didn't create the 6.1.0b1 tag to trigger the image builds yet? |
A reason: No not really, I merged this branch after all feedback was taken into account and I ran the workflow manually on the 6.1.x to test the image with the things we fixed here. But I didn't continue or finish the release after that. I do see now docker description was also triggered maybe from the testing workflow, that's a bit odd. |
@fredvd Okay. I pushed the tag. |
I have created branch 6.1.x as simple copy of 6.0.1, and have now created a branch to use 6.1.0b1, which I have just tagged and released on dist.plone.org.
I might very well overlook stuff that needs to be done for a first Docker release in the 6.1.x series.
Also, we may need to come up with a better way to show the table of latest releases: when we do a 6.0.14 release, it would be tedious to have to update both the 6.0.x and 6.1.x branches.