Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.11 #95

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Use Python 3.11 #95

merged 8 commits into from
Dec 6, 2022

Conversation

jensens
Copy link
Member

@jensens jensens commented Nov 28, 2022

@jensens jensens added the 04 type: enhancement making existing stuff better label Nov 28, 2022
Copy link
Contributor

@Rudd-O Rudd-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra twin turbo hotness.

@jensens jensens temporarily deployed to DOCKER_HUB December 1, 2022 08:34 Inactive
@jensens
Copy link
Member Author

jensens commented Dec 1, 2022

The possible problem is, there are some packages with C-extensions in the Zope world pulled in and the image does not provide a build environment by default.

@jensens
Copy link
Member Author

jensens commented Dec 1, 2022

tests are passing, it is not working anyway.

@jensens jensens added the 22 status: in-progress somebody works on the issue label Dec 1, 2022
@jensens jensens temporarily deployed to DOCKER_HUB December 1, 2022 10:13 Inactive
@jensens jensens added 12 prio: high should be fixed soon and removed 22 status: in-progress somebody works on the issue labels Dec 1, 2022
@jensens jensens added the 24 status: ready for a PR it means, tests passing, merge me asap label Dec 1, 2022
@jensens jensens requested review from ericof and davisagli December 1, 2022 10:20
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@jensens jensens temporarily deployed to DOCKER_HUB December 1, 2022 12:12 Inactive
@jensens jensens requested a review from ericof December 1, 2022 12:30
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having an image with Python 3.11 sounds good, but it is also a significant change. There may be addons or project code that is not compatible with it yet. Do we need to consider publishing images for multiple versions of Python?

@Rudd-O
Copy link
Contributor

Rudd-O commented Dec 5, 2022

Having an image with Python 3.11 sounds good, but it is also a significant change. There may be addons or project code that is not compatible with it yet. Do we need to consider publishing images for multiple versions of Python?

I think the risk that code which worked with Python 3.9 and won't work with Python 3.11 is fairly low, and worth the benefits.

@jensens
Copy link
Member Author

jensens commented Dec 5, 2022

Two more thoughts:

  • performance is much better
  • green IT -> lower CO2 footprint

@jensens jensens temporarily deployed to DOCKER_HUB December 5, 2022 12:29 Inactive
@davisagli
Copy link
Member

I won't block this (I want to try Python 3.11 also). But I do think there is a nonzero chance we'll need to start building an image with Python 3.10 as well, for example if there are addons which are not compatible with Python 3.10 yet.

@jensens
Copy link
Member Author

jensens commented Dec 6, 2022

But I do think there is a nonzero chance we'll need to start building an image with Python 3.10 as well, for example if there are addons which are not compatible with Python 3.10 yet.

I think this is fine, but I would wait for complaints instead of providing one proactive. I go for merge.

@jensens jensens temporarily deployed to DOCKER_HUB December 6, 2022 12:14 Inactive
@jensens jensens merged commit 9843aa9 into 6.0.x Dec 6, 2022
@jensens jensens deleted the jensens-py11 branch December 6, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 type: enhancement making existing stuff better 12 prio: high should be fixed soon 24 status: ready for a PR it means, tests passing, merge me asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GHCR for test image
4 participants