Create string search operator #148
Conversation
|
@instification thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
| @@ -795,6 +803,7 @@ | |||
| <value key="sortable">False</value> | |||
| <value key="operations"> | |||
| <element>plone.app.querystring.operation.string.contains</element> | |||
| <element>plone.app.querystring.operation.string.search</element> | |||
There was a problem hiding this comment.
So if an editor is configuring a search block and adds a criterion with the SearchableText index, they'll have to pick between "Contains" or "Search" as the operation. That seems like bad UX since it's not clear why to choose one or the other.
If you need this for integration with elasticsearch, wouldn't it make more sense for your elasticsearch integration package or your policy package to add this operation (and probably remove the other one)?
|
Closing this PR. As per review comments this functionality is best suited elsewhere |
Currently the only operator for searching strings is the
containsoperator which modifies the search term before running the query.The creation of a search operator allows a search to be performed without munging the search term. This allows for exact matching in searches.
The primary use case for driving this PR is to be able to provide the search term to collective.elasticsearch without modification so that elastic can be used to parse the search original phrase.