Add support for accept attribute on file input. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has set (the field has set by default) the allowed content types are rendered as attribute on the file input. This already restricts the allowed file types before uploading while still being checked on the server side too. Fixes: plone/plone.formwidget.namedfile#66 Depeds on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has set (the field has set by default) the allowed content types are rendered as attribute on the file input. This already restricts the allowed file types before uploading while still being checked on the server side too. Fixes: plone/plone.formwidget.namedfile#66 Depeds on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
force-pushed
the
allowed_content_types
branch
2 times, most recently
from
865daeb
to
e1fee05
Compare
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has `allowedContentTypes` set (the `NamedImage` field has `image/*` set by default) the allowed content types are rendered as `accept` attribute on the file input. This already restricts the allowed file types before uploading while still being checked on the server side too. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has `allowedContentTypes` set (the `NamedImage` field has `image/*` set by default) the allowed content types are rendered as `accept` attribute on the file input. This already restricts the allowed file types before uploading while still being checked on the server side too. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
force-pushed
the
allowed_content_types
branch
2 times, most recently
from
27b3e28
to
0fcafce
Compare
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
added a commit
to plone/plone.app.z3cform
that referenced
this pull request
Mar 14, 2024
If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67
thet
force-pushed
the
allowed_content_types
branch
from
0fcafce
to
96db8cc
Compare
|
I have released plone.namedfile 6.3.0 and have updated the versions/constraints on https://dist.plone.org/release/6.0-dev/ and https://dist.plone.org/release/6.1-dev/ |
thet
force-pushed
the
allowed_content_types
branch
from
5b49d4d
to
f9f76c4
Compare
|
@jenkins-plone-org please run jobs |
If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: #66 Depends on: plone/plone.namedfile#158 [thet]
thet
force-pushed
the
allowed_content_types
branch
from
f9f76c4
to
57815fe
Compare
|
@jenkins-plone-org please run jobs |
mauritsvanrees
approved these changes
Mar 15, 2024
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Mar 15, 2024
Branch: refs/heads/4.3.x Date: 2024-03-14T21:26:02+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@dada24f Add support for the "accept" attribute on file inputs. If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67 Files changed: A news/198.feature M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt M setup.py Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-14T23:01:38+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@623e413 file input: Show accepted media types. Files changed: M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T12:40:14+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@e58d843 Update plone/app/z3cform/templates/image_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T12:40:23+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@cd8690a Update plone/app/z3cform/templates/image_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T12:40:38+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@be47183 Update plone/app/z3cform/templates/file_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/file_input.pt Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T12:40:49+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@2071ff4 Update plone/app/z3cform/templates/file_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/file_input.pt Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T14:40:15+01:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.z3cform@f327f33 Depend on the just released plone.formwidget.namedfile 3.1.0. Files changed: M setup.py Repository: plone.app.z3cform Branch: refs/heads/4.3.x Date: 2024-03-15T16:35:05+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@dc9ccae Merge pull request #199 from plone/allowed_content_types--4.3.x Add support for accept attribute on file input (4.3.x branch) Files changed: A news/198.feature M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt M setup.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Mar 15, 2024
Branch: refs/heads/master Date: 2024-03-14T21:25:17+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@c52dd4e Add support for the "accept" attribute on file inputs. If the widget's field - if there is one - has the "accept" attribute set (the `NamedImage` field has `image/*` set by default) then this is rendered as an `accept` attribute on the file input. This would restrict the allowed file types before uploading while still being checked on the server side. Fixes: plone/plone.formwidget.namedfile#66 Depends on: - plone/plone.namedfile#158 - plone/plone.formwidget.namedfile#67 Files changed: A news/198.feature M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt M setup.py Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-14T23:02:39+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@c6e1d78 file input: Show accepted media types. Files changed: M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T12:41:28+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@f7236d3 Update plone/app/z3cform/templates/image_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T12:41:38+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@5d6d0e7 Update plone/app/z3cform/templates/image_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/image_input.pt Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T12:41:47+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@e4b11e6 Update plone/app/z3cform/templates/file_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/file_input.pt Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T12:41:54+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@b45fb30 Update plone/app/z3cform/templates/file_input.pt Co-authored-by: Maurits van Rees <[email protected]> Files changed: M plone/app/z3cform/templates/file_input.pt Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T14:33:28+01:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.z3cform@dc8eaac Depend on the just released plone.formwidget.namedfile 3.1.0. Files changed: M setup.py Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T14:45:09+01:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.z3cform@4262f25 Configuring with plone/meta Files changed: A dependabot.yml M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M pyproject.toml M tox.ini Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T14:50:51+01:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/plone.app.z3cform@8b5d2aa dependencychecker: ignore plone.formwidget.namedfile. z3c.dependencychecker says this dependency is not needed, but it is wrong: it is used in widgets.zcml. Files changed: M .meta.toml M pyproject.toml Repository: plone.app.z3cform Branch: refs/heads/master Date: 2024-03-15T16:37:34+01:00 Author: Johannes Raggam (thet) <[email protected]> Commit: plone/plone.app.z3cform@f081ed7 Merge pull request #200 from plone/allowed_content_types Add support for accept attribute on file input. Files changed: A dependabot.yml A news/198.feature M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M plone/app/z3cform/templates/file_input.pt M plone/app/z3cform/templates/image_input.pt M pyproject.toml M setup.py M tox.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR Depeds on plone/plone.namedfile#158
If the widget's field - if there is one - has
allowedContentTypesset (theNamedImagefield hasimage/*set by default) the allowed content types are rendered asacceptattribute on the file input.This already restricts the allowed file types before uploading while still being checked on the server side too.
Fixes: #66
Depeds on: plone/plone.namedfile#158