Added adapter scales for INavigationRoot
#165
Conversation
|
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
sneridagh
changed the title
scales for INavigationRoot
sneridagh
changed the title
scales for INavigationRootscales for INavigationRoot
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
I think we should make sure the portal has the IImageScaleTraversable marker, instead of registering this new view. It is more likely to work in general instead of just fixing one piece. And I don't really understand this NavigationRootScaling class or why it exists, so I want to avoid adding more dependencies on it.
However, I couldn't reproduce the problem and I found that the portal already has IImageScaleTraversable -- see my comment #164 (comment)
So we have to investigate why it didn't work for you and understand the situation better before we try to fix it.
|
Closing since it seems this was already fixed in Plone 6.1 |
Closes: #164