Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup tests: reset SKIP_PTA to whatever it was #168

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Fixup tests: reset SKIP_PTA to whatever it was #168

merged 3 commits into from
Oct 20, 2023

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Oct 20, 2023

Before it would leak into other tests, enabling the publication check when it shouldn't be active.

@jaroel
Reset SKIP_PTA to whatever it was.
1bd2477 
Before it would leak into other tests, enabling the publication check when it shouldn't be active.
@mister-roboto
Copy link

@jaroel thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jaroel
Copy link
Member Author

jaroel commented Oct 20, 2023

@jenkins-plone-org please run jobs

@jaroel jaroel requested a review from mauritsvanrees October 20, 2023 13:37
@jaroel
Copy link
Member Author

jaroel commented Oct 20, 2023

I'm so sorry about this whole mess

@jaroel jaroel mentioned this pull request Oct 20, 2023
Merged
wesleybl
wesleybl requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to Changes.

@jaroel jaroel requested a review from wesleybl October 20, 2023 14:19
wesleybl
wesleybl requested changes Oct 20, 2023
View reviewed changes
news/168.bugfix Outdated Show resolved Hide resolved
@jaroel jaroel changed the title Reset SKIP_PTA to whatever it was Fixup tests: reset SKIP_PTA to whatever it was Oct 20, 2023
@wesleybl
Copy link
Member

@jenkins-plone-org please run jobs

@jaroel
Copy link
Member Author

jaroel commented Oct 20, 2023

It's fine, https://jenkins.plone.org/job/pull-request-6.1-3.11/341/ already passed with these changes

davisagli
davisagli approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, the dark ages before pytest fixtures

@davisagli
Copy link
Member

The jenkins failure is an unrelated robot test. I'll merge.

@davisagli davisagli merged commit 772e5b6 into main Oct 20, 2023
10 checks passed
@davisagli davisagli deleted the explicitacquisition-fixup-2 branch October 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleybl wesleybl wesleybl requested changes

@davisagli davisagli davisagli approved these changes

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaroel @mister-roboto @wesleybl @davisagli