Fix no router link in logo (#5981)

plone · Apr 25, 2024 · 8c37e24 · 8c37e24
1 parent 03bcf2e
commit 8c37e24
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/packages/volto/news/5981.bugfix b/packages/volto/news/5981.bugfix
@@ -0,0 +1 @@
+Fix no router link in logo @sneridagh
diff --git a/packages/volto/src/components/theme/Logo/Logo.jsx b/packages/volto/src/components/theme/Logo/Logo.jsx
@@ -7,7 +7,7 @@ import { useEffect } from 'react';
 import { Image } from 'semantic-ui-react';
 import LogoImage from '@plone/volto/components/theme/Logo/Logo.svg';
 import { useSelector, useDispatch } from 'react-redux';
-import { useLocation } from 'react-router-dom';
+import { Link, useLocation } from 'react-router-dom';
 import { getNavroot } from '@plone/volto/actions';
 import {
   flattenToAppURL,
@@ -48,7 +48,7 @@ const Logo = () => {
   const navRootPath = flattenToAppURL(navroot?.navroot?.['@id']) || '/';
 
   return (
-    <a href={navRootPath} aria-label={intl.formatMessage(messages.home)}>
+    <Link to={navRootPath} aria-label={intl.formatMessage(messages.home)}>
       <Image
         src={
           site['plone.site_logo']
@@ -59,7 +59,7 @@ const Logo = () => {
           intl.formatMessage(messages.logoOf) + ' ' + site['plone.site_title']
         }
       />
-    </a>
+    </Link>
   );
 };
 

diff --git a/packages/volto/src/components/theme/Logo/__snapshots__/Logo.Multilingual.test.jsx.snap b/packages/volto/src/components/theme/Logo/__snapshots__/Logo.Multilingual.test.jsx.snap
@@ -4,6 +4,7 @@ exports[`Multilingual Logo renders a logo component in a multilingual site langu
 <a
   aria-label="Home"
   href="/en"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -17,6 +18,7 @@ exports[`Multilingual Logo renders a logo component in a multilingual site root
 <a
   aria-label="Home"
   href="/en"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -30,6 +32,7 @@ exports[`Multilingual Logo renders a logo component with a custom logo in a non-
 <a
   aria-label="Home"
   href="/en"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -43,6 +46,7 @@ exports[`Multilingual Logo renders a logo component with a custom logo in a non-
 <a
   aria-label="Home"
   href="/en"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"

diff --git a/packages/volto/src/components/theme/Logo/__snapshots__/Logo.test.jsx.snap b/packages/volto/src/components/theme/Logo/__snapshots__/Logo.test.jsx.snap
@@ -4,6 +4,7 @@ exports[`Logo renders a logo component with a custom logo 1`] = `
 <a
   aria-label="Home"
   href="/"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -17,6 +18,7 @@ exports[`Logo renders a logo component with a custom logo in a non-root url 1`]
 <a
   aria-label="Home"
   href="/"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -30,6 +32,7 @@ exports[`Logo renders a logo component with default config 1`] = `
 <a
   aria-label="Home"
   href="/"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"
@@ -43,6 +46,7 @@ exports[`Logo renders a logo component with default config in a non-root url 1`]
 <a
   aria-label="Home"
   href="/"
+  onClick={[Function]}
 >
   <img
     alt="Logo of Plone Site"