Update docs/…/blocks/ #3272
Draft
Update docs/…/blocks/ #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevepiercy
requested changes
Apr 27, 2022
…new line. Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
approved these changes
Apr 27, 2022
sneridagh
approved these changes
Apr 29, 2022
|
@ksuess this needs a changelog entry. |
✅ Deploy Preview for plone-components canceled.
|
|
@ksuess @stevepiercy I guess we can easily resurrect this one. |
|
I don't know why it is draft, it's a good improvement. I'll push in a changelog, so it can go out of draft status and we can get it merged. |
|
Oh, nm, @ksuess asked two questions that have yet to be answered in her description. I don't have answers for either question, unfortunately. If anyone can answer the questions, I can provide the assist to polish up the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand:
Then you define the block, using the object described in the example.
https://github.com/plone/volto/blame/master/docs/source/blocks/settings.md#L125
What do I have to do and where do I have to do what?
We also add this piece of code in order to define i18n literals for our new block:
https://github.com/plone/volto/blame/master/docs/source/blocks/settings.md#L127
Where do I add this translation?