Strip ++api++ from in-browser location changes
#4834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
JeffersonBledsoe
changed the title
++api++ from location changes++api++ from in-browser location changes
mamico
reviewed
Jun 5, 2023
| const { externalRoutes = [] } = config.settings; | ||
|
|
||
| const route = externalRoutes.find((route) => | ||
| matchPath(pathname, route.match), | ||
| ); | ||
|
|
||
| let actionToSend = action; |
There was a problem hiding this comment.
AFAIK here, in Javascript, actionToSend is a reference to action. So removing this assignment, and directly changing the action object above, has the same effect. Otherwise, if the intent was to keep the action object as is, there is a problem.
|
GitHub bug meant I had to close this PR and re-open it in #4854 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the Volto part of #4800. We're stripping the
++api++if it is in a location change as we probably don't want to ever navigate directly to a page with++api++in it in the browser. Change the action causes the redux store to be correct, but the URL updating occurs earlier in the react-router stack, and so we also manually update the URL to not have++api++in it. History is still preserved correctly (++api++pages aren't in the history stack but we can still go back and forwards normally).The logic is currently mixed in with the
blacklistRoutesmiddleware while I get some feedback, but this logic should probably be its own middleware for readability.