document the querystringSearchGet setting #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevepiercy
requested changes
Sep 21, 2023
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
|
Thanks @stevepiercy !!!! |
stevepiercy
requested changes
Sep 21, 2023
sneridagh
added a commit
that referenced
this pull request
Sep 26, 2023
* master: fix preview image (#5153) fixed deprecated buffer.from (#5205) feat: add canonical link (#5215) Fix links to link integrity in delete modal (#5226) (fixes #5124) Enhance Accessibility, Add aria-label to search. (#5224) document the querystringSearchGet setting (#5206) Fix empty slate text block in table of contents (#5156)
|
@robgietema @erral @tisto have you had any problems using GET on production sites? |
|
@wesleybl We are using it on a large site and haven't had any problems, but there could be a problem if there are too many criteria. |
|
@wesleybl I just pushed updated docs with an explanation about the hazards of GET requests with a large querystring: https://6.docs.plone.org/volto/configuration/settings-reference.html#main-settings Scroll to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4658 and plone/plone.restapi#1252
The setting is not documented in the setting reference, and it is worth to have it there.