Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass reviewdog and install Vale directly #5256

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Bypass reviewdog and install Vale directly #5256

merged 9 commits into from
Oct 2, 2023

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Oct 1, 2023

Resolve failing CI build due to reviewdog breakage. See #5253

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 86eeccc
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/651979ae78f60b0008951caa

@stevepiercy stevepiercy requested a review from sneridagh October 1, 2023 13:44
@stevepiercy
Copy link
Collaborator Author

@sneridagh this is ready for review. I pulled configuration from plone/documentation. It now runs Vale, but with the flag --no-exit which means "Don't return a nonzero exit code on errors." It also eliminates reviewdog as the test runner.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy Thanks, LGTM

@davisagli davisagli merged commit ad818cf into main Oct 2, 2023
47 checks passed
@davisagli davisagli deleted the restore-vale branch October 2, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants