plone · sneridagh · Jun 18, 2024 · Dec 5, 2023 · Dec 5, 2023 · Dec 6, 2023
diff --git a/packages/volto-slate/news/5452.bugfix b/packages/volto-slate/news/5452.bugfix
@@ -0,0 +1 @@
+Fixed markup shortcut for heading and blockquote @kHAPPY2004
diff --git a/packages/volto-slate/src/constants.js b/packages/volto-slate/src/constants.js
@@ -22,6 +22,9 @@ export const P = 'p';
 export const LI = 'li';
 export const UL = 'ul';
 export const OL = 'ol';
+export const H2 = 'h2';
+export const H3 = 'h3';
+export const BLOCKQUOTE = 'blockquote';
 
 // dom parsing node information
 export const TEXT_NODE = 3;

diff --git a/packages/volto-slate/src/editor/plugins/Markdown/constants.js b/packages/volto-slate/src/editor/plugins/Markdown/constants.js
@@ -1,6 +1,6 @@
 import { toggleList } from './utils';
 import { isBlockActive } from '@plone/volto-slate/utils';
-import { UL, OL, LI } from '@plone/volto-slate/constants';
+import { UL, OL, LI, H2, H3, BLOCKQUOTE } from '@plone/volto-slate/constants';
 
 /**
  * Uses the old toggleList function to toggle lists on or off or from a type to another.
@@ -22,11 +22,11 @@ export const localToggleList = (editor, format) => {
  */
 export const autoformatRules = [
   {
-    type: 'h2',
+    type: H2,
     markup: '#',
   },
   {
-    type: 'h3',
+    type: H3,
     markup: '##',
   },
   {
@@ -44,7 +44,7 @@ export const autoformatRules = [
     },
   },
   {
-    type: 'blockquote',
+    type: BLOCKQUOTE,
     markup: ['>'],
     // preFormat,
   },

diff --git a/packages/volto-slate/src/editor/plugins/Markdown/extensions.js b/packages/volto-slate/src/editor/plugins/Markdown/extensions.js
@@ -197,11 +197,7 @@ export const autoformatBlock = (editor, type, at, { preFormat, format }) => {
   }
 
   if (!format) {
-    Transforms.setNodes(
-      editor,
-      { type },
-      { match: (n) => Editor.isBlock(editor, n) },
-    );
+    Transforms.setNodes(editor, { type });
   } else {
     format(editor);
   }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed markup shortcut for heading and blockquote @kHAPPY2004
Copy link Collaborator stevepiercy Dec 5, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. What exactly was broken, and how was it fixed? Please include some details, such as what was the original broken behavior and what is the new fixed behavior. These change log entries appear in documentation upon release, so they should be helpful to a developer looking to fix a broken behavior that they observed.