Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put cloneData function for slate block, in order to change the uuids of fragments #5518
base: main
Are you sure you want to change the base?
Put cloneData function for slate block, in order to change the uuids of fragments #5518
Changes from 8 commits
6cdacde
ff4d5b7
a687633
2018042
707fb03
ed7f975
c616845
aff3697
511e99d
6d2af88
122322b
b756359
a5ffdba
4892569
8803484
8ba748d
6e4c175
d29d9d9
6d67579
fdec971
5df64d1
c74033c
f3cef86
2b66e67
f193a9f
c55caae
ee15648
05aabd6
20680f6
d3ae95e
c6e7ef4
f98b7a6
d62d505
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this add
children
to nodes that should not have it, like text nodes?I would really like to see a test for this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is true, I will modify, and add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will add a uid even if there wasn't one there before; is that what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that all children have uid by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so. I have not seen it before.