Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5566 dropdown popup positioning in contents page #5622

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kanhaiya04
Copy link

Fixed #5566,

Implemented the dropdown with PopperJS.

Screencast.from.14-01-24.02.56.01.PM.IST.mp4

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f19e91d
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65b147a60ffb13000762007e

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit f19e91d
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65b147a60a4a470009eb7894
😎 Deploy Preview https://deploy-preview-5622--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mister-roboto
Copy link

@kanhaiya04 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@kanhaiya04
Copy link
Author

@kanhaiya04 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

I have signed the agreement on 12 Jan.
Why is still showing this??

@stevepiercy
Copy link
Collaborator

@kanhaiya04 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

I have signed the agreement on 12 Jan. Why is still showing this??

From that very page, which you, of course, read before signing and returning the Plone Contributor Agreement, right? 😉

I signed the Agreement, but haven't been given access yet.
Please allow a few days of response time; the handling of Contributor Agreements is done by volunteers. If you have issues, or for instance think you may have made a spelling error in your email or github username, contact [email protected]

Additionally, please read and follow Contributing to Plone and First-time contributors.

@kanhaiya04 kanhaiya04 force-pushed the DropdownPopupPositioningInContentsPage#4756 branch from 0459097 to d2daf1c Compare January 21, 2024 15:52
@stevepiercy stevepiercy requested a review from sneridagh January 23, 2024 22:36
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to clarify the change log entry.

packages/volto/news/5566.bugfix Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News item looks good, but the rest of the PR still needs review by a core contributor.

@ichim-david
Copy link
Member

I'll try to have a look at this today, but no promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs discussion
Development

Successfully merging this pull request may close these issues.

UI Issue : dropdown popup positioning in contents page
4 participants