-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #5566 dropdown popup positioning in contents page #5622
base: main
Are you sure you want to change the base?
Fixed #5566 dropdown popup positioning in contents page #5622
Conversation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kanhaiya04 you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
I have signed the agreement on 12 Jan. |
From that very page, which you, of course, read before signing and returning the Plone Contributor Agreement, right? 😉
Additionally, please read and follow Contributing to Plone and First-time contributors. |
0459097
to
d2daf1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to clarify the change log entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News item looks good, but the rest of the PR still needs review by a core contributor.
I'll try to have a look at this today, but no promises. |
Fixed #5566,
Implemented the dropdown with PopperJS.
Screencast.from.14-01-24.02.56.01.PM.IST.mp4