Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accordion to metadata form. #5760

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Add accordion to metadata form. #5760

merged 9 commits into from
Feb 21, 2024

Conversation

robgietema
Copy link
Member

@robgietema robgietema commented Feb 13, 2024

This PR add the feature to collapse and expand fieldsets in the metadata form in the sidebar. A helper method is also added which can be used to scroll to a specific field and focus on it.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 76cbfe2
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65d5c6d63856600008b949ba

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 76cbfe2
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65d5c6d660d8160008acb655
😎 Deploy Preview https://deploy-preview-5760--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robgietema robgietema requested a review from sneridagh February 13, 2024 16:07
@sneridagh
Copy link
Member

@robgietema can we have some docs on how to use it?

@stevepiercy
Copy link
Collaborator

Would this be the appropriate location for developer docs for this feature? Forms and widgets

@robgietema
Copy link
Member Author

I've added some docs in the location specified by Steve.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few spelling, grammar, and style fixes. Thank you!

packages/volto/news/5760.feature Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
docs/source/recipes/widget.md Outdated Show resolved Hide resolved
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good. Thank you!

@sneridagh sneridagh merged commit 4e0b708 into main Feb 21, 2024
65 checks passed
@sneridagh sneridagh deleted the metadata-form-accordion branch February 21, 2024 10:00
sneridagh added a commit that referenced this pull request Feb 21, 2024
Co-authored-by: Víctor Fernández de Alba <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
sneridagh added a commit that referenced this pull request Feb 28, 2024
* main: (43 commits)
  5645 toolbar buttons toggle when clicking same toolbar button (#5795)
  fix: array widget sort (#5805)
  Fix a11y logo issue (#5776)
  Improve Vite PoC - Add BlockRenderer and `@plone/blocks` to the party (#5798)
  Removed memori websites that give 404 since they are no longer using Volto (#5803)
  Release Management Notes (#5358)
  Enhance findBlocks to check for blocks in data for add-ons (#5797)
  Release @plone/components 2.0.0-alpha.2
  Move basic default CSS out of theme. Improve StoryBook intro page (#5791)
  Switch peerDependencies to Volto 18 for generator-volto alpha's/latest. (#5781)
  Release 18.0.0-alpha.13
  Release @plone/slate 18.0.0-alpha.7
  Fix sidebar form update. (#5779)
  Add uncommited types for release??
  Release 18.0.0-alpha.12
  Add accordion to metadata form. (#5760)
  Release @plone/registry 1.3.1
  [registry] Export Config type as ConfigType, amend coresandbox (#5774)
  Release @plone/components 2.0.0-alpha.1
  Add import path for compiled CSS (#5770)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants