Fix a11y logo issue #5776
Merged
Fix a11y logo issue #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
Molochem
requested review from
stevepiercy,
JeffersonBledsoe,
erral,
davisagli and
sneridagh
stevepiercy
previously requested changes
Feb 20, 2024
There was a problem hiding this comment.
There was still disagreement on how to proceed. I think this PR should be closed until there is agreement.
Aside from that "Front Page" is seldom used for websites. It's more for newspapers, when there was such a thing 😜 .
"Home" is much more common usage and already exists in the language files, so let's reuse that.
We definitely do not want to include "Back to ". How do you know that someone came from that location and not directly to that page?
|
@stevepiercy let's keep the discussion in the issue: #5720 (comment) |
|
@tisto I already made similar comments previously in that issue, except for the disagreement. I don't know why they were not seen. Maybe I need to work on my accessibility? 🤣 |
stevepiercy
previously requested changes
Feb 26, 2024
Co-authored-by: Steve Piercy <[email protected]>
sneridagh
previously requested changes
Feb 27, 2024
packages/volto/src/components/theme/Logo/__snapshots__/Logo.Multilingual.test.jsx.snap
Outdated
Show resolved
Hide resolved
JeffersonBledsoe
approved these changes
Feb 27, 2024
sneridagh
added a commit
that referenced
this pull request
Feb 28, 2024
* main: (43 commits) 5645 toolbar buttons toggle when clicking same toolbar button (#5795) fix: array widget sort (#5805) Fix a11y logo issue (#5776) Improve Vite PoC - Add BlockRenderer and `@plone/blocks` to the party (#5798) Removed memori websites that give 404 since they are no longer using Volto (#5803) Release Management Notes (#5358) Enhance findBlocks to check for blocks in data for add-ons (#5797) Release @plone/components 2.0.0-alpha.2 Move basic default CSS out of theme. Improve StoryBook intro page (#5791) Switch peerDependencies to Volto 18 for generator-volto alpha's/latest. (#5781) Release 18.0.0-alpha.13 Release @plone/slate 18.0.0-alpha.7 Fix sidebar form update. (#5779) Add uncommited types for release?? Release 18.0.0-alpha.12 Add accordion to metadata form. (#5760) Release @plone/registry 1.3.1 [registry] Export Config type as ConfigType, amend coresandbox (#5774) Release @plone/components 2.0.0-alpha.1 Add import path for compiled CSS (#5770) ...
sneridagh
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #5720 , i've implemented the changes