Pin eslint-plugin-jsx-a11y to ^6.7.1 everywhere it's referenced #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added the disabling "jsx-a11y/label-has-associated-control" in case it reaches version 6.8.0 as we have failures within Volto
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
sneridagh
reviewed
Feb 26, 2024
| @@ -27,7 +27,8 @@ | |||
| ], | |||
| "react-hooks/rules-of-hooks": "error", | |||
| "react-hooks/exhaustive-deps": "warn", | |||
| "react/react-in-jsx-scope": "off" | |||
| "react/react-in-jsx-scope": "off", | |||
There was a problem hiding this comment.
For 18 alpha is not really required, we only need to add an entry to the upgrade guide.
sneridagh
added a commit
that referenced
this pull request
May 13, 2024
* main: Revert "Fix 301 and 302 redirects. (#5999)" (#6008) Pin eslint-plugin-jsx-a11y to ^6.7.1 everywhere it's referenced (#5794) Allow Makefile to be modified by Makefile.local if present (#5997) Cypress replaced wait with assertions (#5998) Replace spinner with Progress bar and fix it's position . (#5620) (#5929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5785