Notify in documentation useLinkedHeadings setting change after changes from #5225 #5885
Conversation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
| @@ -245,12 +245,12 @@ slate.runtimeDecorators = [([node, path], ranges) => ranges]; | |||
|
|
|||
| The setting `slate.useLinkedHeadings` controls whether `volto-slate` creates anchors for headings, such as `h1` and `h2`, in the editor. | |||
|
|
|||
| The default setting is `true`. | |||
| The default setting is `false`. | |||
There was a problem hiding this comment.
This doesn't match what I see in the code.
It creates anchor links unless the setting is explicitly equal to false:
So if useLinkedHeadings isn't set, it has the same effect as setting it to true.
There was a problem hiding this comment.
This doesn't match what I see in the code.
It creates anchor links unless the setting is explicitly equal to
false:So if useLinkedHeadings isn't set, it has the same effect as setting it to true.
@davisagli you are correct the setting is missing, and therefore it is opt-out.
I would add a note that mentions in the documentation for this setting that it will add the anchors only
for logged in users after whatever version made those changes.
What do you think about my idea, would you add this info somewhere else?
There was a problem hiding this comment.
@ichim-david yeah, it makes sense to clarify that the feature is only for editors
ichim-david
force-pushed
the
5885-linked-heading-docs
branch
from
6f34c7f to
0deb876
Compare
ichim-david
changed the title
|
@davisagli I know that we had these changes #5225 due to #5174 but it rubs me the wrong way that we make an assumption about this feature being useful only for logged-in users. If you want to enable for everyone you need to customize the render file just to remove the token condition. What do you think about another option skipLinkedHeadlinesForAnon set to true by default? |
docs/source/configuration/volto-slate/configuration-settings.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Piercy <[email protected]>
* main: Add new types generator, don't know why they don't get included when releasing Release 18.0.0-alpha.22 Release @plone/registry 1.5.3 Cross-package manager Volto path resolver in webpack-relative-resolver (#5893) New `volto-update-deps` documentation (#5892) Release generate-volto 9.0.0-alpha.13 Release @plone/scripts 3.6.1 Improve and fix volto-update-deps (#5889) Sort facet values if they are numbers (#5865) Release generate-volto 9.0.0-alpha.12 Bump @plone/scripts and @plone/types to latests (#5888) Release 18.0.0-alpha.21 Release @plone/scripts 3.6.0 Release @plone/types 1.0.0-alpha.7 Notify in documentation useLinkedHeadings setting change after changes from #5225 (#5885) Add dependencies syncronizer utility (#5879) Update volto-slate configuration to indicate it is now part of the core. (#5886) Bump all the versions in GitHub workflows (#5873) Added download link to filename in file widget (#5880) Improve `@plone/types` - Block*Props - Widgets (#5876)
No description provided.