Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing step in storybook migration #5913

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Missing step in storybook migration #5913

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
565d062
Missing step in storybook migration
sneridagh Mar 24, 2024
f97beab
Clog
sneridagh Mar 24, 2024
3ece37c
Apply suggestions from code review
sneridagh Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/source/upgrade-guide/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@ Replace the `.storybook` folder in your project with this one:

https://github.com/plone/volto/tree/5605131868689778bbdca0c3003a40cb9f153c1a/packages/generator-volto/generators/app/templates/.storybook

Then update your project's or add-on `scripts` key like:
sneridagh marked this conversation as resolved.
Show resolved Hide resolved

```diff
- "storybook": "start-storybook -p 6006",
- "build-storybook": "build-storybook"
+ "storybook": "storybook dev -p 6006",
+ "build-storybook": "storybook build"
```

```{seealso}
[Migration guide from Storybook 6.x to 8.0](https://storybook.js.org/docs/migration-guide/from-older-version)
Expand Down
1 change: 1 addition & 0 deletions packages/volto/news/5913.documentation
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Missing step in storybook migration @sneridagh
sneridagh marked this conversation as resolved.
Show resolved Hide resolved
Loading