Fix initialValue block setting #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
ichim-david
reviewed
May 1, 2024
In this situation, only the onChangeBlock method was called, which does not call the _applyBlockInitialValue method. Then we call the _applyBlockInitialValue method before calling onChangeBlock.
block In this situation, the insertBlock method is called. But it passed the id of the previous block to the _applyBlockInitialValue method, instead of the id of the new created block.
sneridagh
approved these changes
May 27, 2024
ichim-david
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
initialValueblock setting in two situations:In this situation, only the
onChangeBlockmethod was called, which does not call theapplyBlockInitialValuemethod. Then we call theapplyBlockInitialValuemethod before callingonChangeBlock.In this situation, the
insertBlockmethod is called. But it passed the id of the previous block to theapplyBlockInitialValuemethod, instead of the id of the new created block.fixes #5971