Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sphinx examples, align doc requirements with main documentation #6011

Merged
merged 5 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"sphinx.ext.intersphinx",
"sphinx.ext.todo",
"sphinx_copybutton",
"sphinx_examples",
"sphinxext.opengraph",
"sphinxcontrib.video",
]
Expand Down
6 changes: 3 additions & 3 deletions docs/source/contributing/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ To hyperlink to Storybook entries from the narrative documentation, you can use
Use HTML syntax to enable hyperlinking in development, within Netlify preview builds, and when the main Plone documenation is updated.
Hyperlinking in development requires that you run both `make docs-html` and `make storybook-build` commands once, then whenever you update either the narrative documentation or the Storybook.

% sphinx-examples does not render HTML

```html
<a href="/storybook/index.html?path=/story/edit-widgets-colorpicker--default">color picker widget</a>
```
Expand All @@ -163,8 +165,6 @@ Hyperlinking in development requires that you run both `make docs-html` and `mak

Use CommonMark syntax to point only to the main production Plone documentation.

```md
```{example}
[color picker widget](https://6.docs.plone.org/storybook/index.html?path=/story/edit-widgets-colorpicker--default)
```

[color picker widget](https://6.docs.plone.org/storybook/index.html?path=/story/edit-widgets-colorpicker--default)
2 changes: 1 addition & 1 deletion docs/source/upgrade-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Then update the version of `@plone/scripts` to at least version `3.6.1`.
The following example shows the minimum valid versions to use under the `dependencies` key.

```json
dependencies: {
"dependencies": {
"@plone/volto": "18.0.0-alpha.21",
"@plone/scripts": "^3.6.1"
}
Expand Down
1 change: 1 addition & 0 deletions packages/volto/news/6011.documentation
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add sphinx-examples extension, update examples, align docs requirements with main documentation, and fix JSON example in upgrade guide. @stevepiercy
10 changes: 5 additions & 5 deletions requirements-docs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@ docutils<0.17,>=0.15 # sphinx-book-theme 0.2.0 has requirement docutils<0.17,>=
Sphinx<5,>=3 # sphinx-book-theme 0.3.3 has requirement sphinx<5,>=3
lesscpy
linkify-it-py
myst-parser==1.0.0 # Temporary pin until theme is updated.
myst-parser
pydata-sphinx-theme<=0.8.99 # Build fails in 0.9.0. See https://github.com/plone/documentation/issues/1297
sphinx-autobuild
pydata-sphinx-theme<=0.8.99
sphinx-book-theme==0.3.3
sphinx-book-theme==0.3.3 # Temporary pin until we can sort out HTML refactoring.
sphinx-copybutton
sphinx-examples
sphinx-sitemap
sphinx-togglebutton
sphinxcontrib-spelling
sphinxext-opengraph
sphinxcontrib-applehelp==1.0.4 # https://github.com/plone/documentation/issues/1604
sphinxcontrib-devhelp==1.0.2 # https://github.com/plone/documentation/issues/1604
sphinxcontrib-htmlhelp==2.0.1 # https://github.com/plone/documentation/issues/1604
sphinxcontrib-qthelp==1.0.3 # https://github.com/plone/documentation/issues/1604
sphinxcontrib-serializinghtml==1.1.5 # https://github.com/plone/documentation/issues/1604
sphinxcontrib-video
sphinxext-opengraph
vale==2.30.0
Loading