fixes issue #6283 and #6300 #6337
Conversation
✅ Deploy Preview for plone-components canceled.
|
|
Could someone take a look when they get a chance? Let me know if anything needs to be changed or if it’s good to go! 🙌 |
|
yeah got it @stevepiercy |
|
@viveak910 did you run tests locally? Please take care. See https://6.docs.plone.org/volto/contributing/testing.html and https://6.docs.plone.org/volto/contributing/acceptance-tests.html |
|
@djay @JeffersonBledsoe could you review this, please? |
|
Hi, everyone. I’m new to this process, and I wanted to check if my PR has been merged or just approved. Should I close the PR myself now that the changes have been approved, or will someone else handle it? Thanks! |
|
@viveak910 a member of the Volto Team will merge the PR. Please do not close and reopen the PR, as each action sends a notification to all subscribers, needlessly spamming them and making them grumpy. |
| // Fixes https://github.com/chimurai/http-proxy-middleware/issues/320 | ||
| if (!req.body || !Object.keys(req.body).length) { | ||
| return; | ||
| } | ||
| // Set headers for the proxy request | ||
| proxyReq.setHeader('X-Real-IP', req.ip); | ||
| proxyReq.setHeader('X-Forwarded-For', req.ip); |
There was a problem hiding this comment.
If the incoming request already has X-Forwarded-For from another proxy, we should keep that value and add req.ip to the end of the list: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For
| "typescript": "^5.4.5", | ||
| "vitest": "^1.5.0" | ||
| "typescript": "^5.6.2", | ||
| "vitest": "^2.1.2" |
There was a problem hiding this comment.
Why/how did you update these dependencies? They should not be included in the PR unless they are required for the change to the proxy. (Same thing for the changes in pnpm-lock.yaml)
Fixed issue #6283 with proxy requests not setting
X-Real-IP,X-Forwarded-For, andX-Forwarded-Hostheaders correctly.