-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types, better exports and use tsup for build, remove parcel #6461
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain more about the switch from parcel to tsup? What's the motivation and are there any tradeoffs?
@davisagli just added some more background in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was parcel
something the developer directly called? If so, does its replacement merit more than a change log entry?
Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy no, always in automated build processes, but they could see when it failed. |
BTW, @davisagli @stevepiercy in the next days, probably I will be replacing (if possible) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really qualified to review the Node/Typescript details here. I'm okay with it as long as there isn't an impact for users.
We are having problems in some setups in macos where
parcel
errors with a segmentation fault and we found also some weird errors related with it inpnpm
lock, where the lock keeps updating because of it (apparently, their entries in the lock keep cycling infinitely). In addition, the resultant code has some weird names with a looong hash that end up in the dev tools. Then I also learned thattsup
is more pure with their outputs and it was the recommended setup, see:https://www.totaltypescript.com/how-to-create-an-npm-package
Totally worth it from top to bottom.
I also fixed the remaining types that forced us to
||true
in the build output. So overall this PR improves the current situation, in a non-breaking way.