-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace parcel
with tsup
. Better types, better tsconfig. Move to ESM.
#6467
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sneridagh What does adding type
in the imports do?
@davisagli type declares the import "Typescript only", so the interpreter knows that it does not belong to the code, so it strips it on build time when transpiling. It's a best practice nowadays. This is enforced by the I'm trying to come up with a golden |
@sneridagh So the type system can't even tell which things are types without giving manual hints? Pssh. |
@davisagli it can, but sometimes it seems it has a hard time doing it, so it's better to explicit tell him :) It kind of makes sense in a bundler world! |
No description provided.