-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved issue Number-6143 #6484
base: main
Are you sure you want to change the base?
Solved issue Number-6143 #6484
Conversation
When selecting a start datetime, the end datetime should be after the start datetime. plone#6143. github - Harshit-7373.
@Harshit-7373 you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have already signed the agreement, please allow a week for your agreement to be processed. If after a week you have not received an invitation, then please contact [email protected]. |
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is not an acceptable solution. This validation should happen on the client side using the existing validation framework that's integrated with the form components in packages/volto. Your solution bypasses most of how Volto works, and only tries to solve this for the experimental vite app.
Thank you for the feedback. I understand now that the validation should be handled on the client side using the existing validation framework integrated with the form components in the packages/volto. I’ll make sure to align with Volto’s existing structure and ensure that the solution does not bypass its core functionality. I’ll update my approach accordingly to work seamlessly with the current framework. Please let me know if you have any further suggestions or if there’s anything else I should consider. |
@Harshit-7373 you can start here https://6.docs.plone.org/volto/configuration/validation.html |
When selecting a start datetime, the end datetime should be after the start datetime. #6143.
github - Harshit-7373.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #