Fixed circular import error in dev with HMR in App component when imported in the main default config
#6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mported in the main default config.
✅ Deploy Preview for plone-components canceled.
|
sneridagh
changed the title
App component when i…App component when imported in the main default config
pnicolli
approved these changes
Dec 9, 2024
sneridagh
added a commit
that referenced
this pull request
Dec 12, 2024
* main: Fixed types declaration extractor from Volto core, re-enable it on release (#6534) Release 18.3.0 Release @plone/slate 18.0.4 Release @plone/helpers 1.0.0 Make helpers release-able Release @plone/registry 2.2.0 Release @plone/components 3.0.0 Release @plone/types 1.1.0 [slots] @plone/slots first developments (#6409) improve link integrity popup (#6516) Add missing styleWrapper style builder information in container/Grid (#6527) update: skip scroll to top on inital SSR completion. (#6523) Release 18.2.3 Fixed circular import error in dev with HMR in core Views and Widgets shadow customizations (#6526) Release 18.2.2 Fixed circular import error in dev with HMR in core Blocks shadow customizations (#6525) Release 18.2.1 Release @plone/slate 18.0.3 Fixed circular import error in dev with HMR in `App` component when imported in the main default config (#6524) Update @plone/* packages info (#6521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 18.2.0, after move the core code to use direct imports in #6509 in projects still using some barrel imports, in dev mode, HMR errored due to a circular import error.
Investigating, I managed to pinpoint the problem in the default config of the component registry, since we have in there
Appregistered. It seems that it's in there to provide maximum flexibility for providing a complete differentApp, if needed. It's used by the old generator, but not anymore by the project-less setup. So it has to go, and use shadowing for that purpose.I'll add a note for React 19 to remove it.
I workaround it by not relying on import/export as side effect for the apply the setting for components, but as a function called exactly where we want it to be applied (hopefully, after all initialization and the import phase).