heme plugin and views to be able to enable and disable theme per user session. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2014 18:22
|
I would suggest using a cookie instead of the Zope session. That way it will work even in a load-balanced configuration without session affinity. |
added 3 commits
November 2, 2014 13:48
…azo) as a fallback theme for Intranet site
|
Sorry, this had been closed by mistake. |
|
please merge in master |
|
@lewicki can you please rebase or merge in master, this is a taks for the ploneintranet stack, all branches should be uptodate tnx |
Conflicts: setup.py src/ploneintranet/theme/profiles/default/registry.xml
|
Minor nitpick: barceloneta is spelled with one t |
|
Also, how about using a cookie, as @davisagli suggested? Session affinity is really undesirable. |
|
From our recollection this was made when ploneintranet was still on Plone 4, so we should check that it works after all our refactoring. |
adrianwhite
changed the title
|
Have create #135 to replace this as the change will require reimplementing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are new views '@@enable_theme' and '@@disable_theme' that allow user to disable theming in current session.