Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain versioning system #294

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Explain versioning system #294

merged 10 commits into from
Oct 2, 2024

Conversation

ndrezn
Copy link
Member

@ndrezn ndrezn commented Apr 25, 2024

Explains how versioning works, and adds a test to ensure we actually follow the system!

tests/test_versioning.py Outdated Show resolved Hide resolved
tests/test_versioning.py Outdated Show resolved Hide resolved
@gvwilson
Copy link
Contributor

@ndrezn @BSd3v can we please give this some love?

@gvwilson gvwilson added documentation written for humans fix fixes something broken P2 considered for next cycle labels Aug 13, 2024
BSd3v and others added 2 commits September 27, 2024 19:12
…fter the build to make sure that the package for the test is the currently coded package. Otherwise you can fail and pass errantly.
@BSd3v
Copy link
Collaborator

BSd3v commented Oct 1, 2024

@ndrezn, @gvwilson, thoughts on the changes?

Should we describe the testing behaviour in the contributing guide?

eg: test_version.py => AG-grid in unison within itself, test_versioning.py DAG is in unison with AG-grid?

@ndrezn
Copy link
Member Author

ndrezn commented Oct 2, 2024

Yes, definitely worth adding a note to the contribution guide. I'm not sure also if we mention running the tests locally but devs probably should be recommended to use pytest --headless -k "not test_versioning" rather than just pytest.

@BSd3v
Copy link
Collaborator

BSd3v commented Oct 2, 2024

test_versioning.py isnt in the tests/ anymore. So they can just run pytest. 😄

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Drezner <[email protected]>
Copy link
Collaborator

@BSd3v BSd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@ndrezn ndrezn merged commit a22ca0e into main Oct 2, 2024
3 checks passed
@ndrezn ndrezn deleted the update-contributing branch October 2, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation written for humans fix fixes something broken P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants