-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radar): add onClick handler #2601
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We are really looking forward to this new feature! Thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, thank you.
However the property should be added to the website (I'm not sure we need a story), also it would be good to add some tests for this new feature.
Thank you for your answer, I will add it to the website and add some tests 👍 Should I remove the story ? |
…icking on the chart display an action log
Hello @plouc , I added a radar test and updated the website Radar.chart._.nivo.-.4.July.2024.mp4 |
…ine in Radar.test
@Nino3103, could you please re-sync with master? I had to upgrade a github action, that's why tests are failing. |
@plouc it's resynced with master, tests are passing now 👍 |
@Nino3103, thank you for your contribution! |
Radar Chart : add onClick handler
Issue : #1003
Video
Radar.-.With.On.Click.Storybook.-.31.May.2024.mp4