feat: Pie: support multiple activeIds
#2670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
plouc
requested changes
Nov 21, 2024
| @@ -20,6 +20,9 @@ import { | |||
| CommonPieProps, | |||
| } from './types' | |||
|
|
|||
| const idIsActive = (id: DatumId, activeId: null | DatumId | DatumId[]) => | |||
There was a problem hiding this comment.
Rather than supporting a scalar or an array, I think it would be better to rename the property to activeIds and to support arrays exclusively.
It would also be nice to add tests about this new feature and to adjust the documentation.
| @@ -282,6 +282,76 @@ export const ControlledActiveId: Story = { | |||
| render: () => <ControlledPies />, | |||
| } | |||
|
|
|||
| const ControlledPiesMultipleActiveIds = () => { | |||
| const [activeId, setActiveId] = useState<string>(commonProperties.data[1].id) | |||
| const [additionalActiveIds, setAdditionalActiveIds] = useState<string>([]) | |||
There was a problem hiding this comment.
The type should be string[] I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.