Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Injection): Display max upload size #386

Merged
merged 3 commits into from
Feb 22, 2024
Merged

feat(Injection): Display max upload size #386

merged 3 commits into from
Feb 22, 2024

Conversation

stonebuzz
Copy link
Contributor

@stonebuzz stonebuzz commented Feb 22, 2024 •
edited
Loading

Display max upload size

image

image

Fix #357

@stonebuzz stonebuzz self-assigned this Feb 22, 2024
@stonebuzz stonebuzz added this to the 2.13.6 milestone Feb 22, 2024
@stonebuzz stonebuzz mentioned this pull request Feb 22, 2024
Closed
Rom1-B
Rom1-B requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, a more explicit error message would also be appreciated.

For the moment, it's always "The file could not be found"?

@stonebuzz
Copy link
Contributor Author

The file could not be found

I've added a message because the IF above doesn't allow me to identify the source of the problem.

@stonebuzz stonebuzz merged commit c4a2611 into main Feb 22, 2024
3 checks passed
@stonebuzz stonebuzz deleted the feat/display_file_size branch February 22, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@stonebuzz stonebuzz

Labels
enhancement
Projects
None yet
Milestone
2.13.6
Development

Successfully merging this pull request may close these issues.

Error: The file could not be found
3 participants
@stonebuzz @Rom1-B @AdrienClairembault