Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for Hooks::SET_ITEM_IMPACT_ICON #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an example for Hooks::SET_ITEM_IMPACT_ICON #55

wants to merge 1 commit into from

Conversation

cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne mentioned this pull request Jul 1, 2024
Merged
AdrienClairembault
AdrienClairembault suggested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example looks correct but could have been achieved by editing directly the config.

Maybe you could add some other condition to illustrate that the hook is meant to impact a subset of items for a given type ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault requested changes

@orthagh orthagh orthagh approved these changes

@trasher trasher trasher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cedric-anne @trasher @orthagh @AdrienClairembault